FSStore: key_separator fix

[joshmoore]

key_separator: fix handling of meta keys

This rebases and cleans a fix from Martin's original PR.
Two new test methods fail without it and pass with since
keys for meta-files like `.zarray` were being converted
into `/zarray`.

see: martindurant@5795bc7

TODO:

• Add unit tests and/or doctests in docstrings
• [] Add docstrings and API docs for any new/modified user-facing classes and functions
• New/modified features documented in docs/tutorial.rst
• Changes documented in docs/release.rst
• AppVeyor and Travis CI passes
• Test coverage is 100% (Coveralls passes)

[pep8speaks]

Hello @joshmoore! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-02-18 07:08:01 UTC

[codecov]

Codecov Report

Merging #699 (6573c55) into master (23422fc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #699   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files          28       28           
  Lines       10263    10286   +23     
=======================================
+ Hits        10257    10280   +23     
  Misses          6        6           

Impacted Files	Coverage Δ
zarr/storage.py	100.00% <100.00%> (ø)
zarr/tests/test_storage.py	100.00% <100.00%> (ø)

[joshmoore]

Doesn't look like restarting picks up the new commits to master. Trying a manual merge of master.

[jakirkham]

Doesn't look like restarting picks up the new commits to master. Trying a manual merge of master.

Yeah I've noticed that about GH Actions. We can fix this manually either by doing it ourselves or adding it to GH Actions. Here's the same idea, but with CircleCI ( scikit-learn/scikit-learn#8211 )

[joshmoore]

Nice idea!

[joshmoore]

Thanks, @martindurant.