Skip to content

Skip datetime, timedelta, and complex with N5Store #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2019
Merged

Skip datetime, timedelta, and complex with N5Store #411

merged 1 commit into from
Feb 26, 2019

Conversation

jakirkham
Copy link
Member

@jakirkham jakirkham commented Feb 26, 2019

The N5 spec does not currently list support for datetime, timedelta, and complex typed data. So customize test_dtype for N5Store to avoid these and instead focus on the types N5Store does support. Should fix the CI failure on master accidentally introduced by PR ( #363 ).

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • Docs build locally (e.g., run tox -e docs)
  • AppVeyor and Travis CI passes
  • Test coverage is 100% (Coveralls passes)

The N5 spec does not currently list support for datetime, timedelta, and
complex typed data. So customize `test_dtype` for `N5Store` to avoid
these and instead focus on the types `N5Store` does support.
@jakirkham jakirkham added this to the v2.3 milestone Feb 26, 2019
@jakirkham jakirkham mentioned this pull request Feb 26, 2019
7 tasks
@jakirkham jakirkham merged commit aa986d4 into zarr-developers:master Feb 26, 2019
@jakirkham jakirkham deleted the fix_n5store_dtype_tst branch February 26, 2019 17:21
@jakirkham
Copy link
Member Author

Merged to fix the build on master. Please let me know if you find an issue in this PR and would be happy to address it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant