fix: raise error when encountering nullable string dtype #3695
+18
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs release notes
github-actions
bot
removed
the
needs release notes
d-v-b
reviewed
Feb 9, 2026
Comment on lines
+162
to
+168
| if dtype.kind == "T" and hasattr(dtype, "na_object"): | ||
| msg = ( | ||
| f"Zarr data type resolution from {dtype} failed. " | ||
| "Attempted to resolve a zarr data type from a `numpy.dtypes.StringDType` " | ||
| "with `na_object` set, which is not supported." | ||
| ) | ||
| raise ValueError(msg) |
Contributor
There was a problem hiding this comment.
Are you OK with moving this logic to the from_native_dtype method on the VariableLengthUTF8 class? It should be after we have checked that the input is numpy StringDType. I'm happy to implement this if that change is OK with you.
Author
There was a problem hiding this comment.
Sure, go ahead! I just wanted to get this started!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3692
TODO:
changes/