Skip to content

Unused import #3121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Unused import #3121

wants to merge 3 commits into from

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Jun 7, 2025 •
edited
Loading

Is it OK for backwards compatibility to remove the ArrayMetadataDict import from src/zarr/api/asynchronous.py?

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.rst
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Jun 7, 2025
@d-v-b
Copy link
Contributor

d-v-b commented Jun 7, 2025

if it's not used, then it can go from my POV

@DimitriPapadopoulos
Copy link
Contributor Author

DimitriPapadopoulos commented Jun 7, 2025 •
edited
Loading

Some of the imports are required by typing casts. Both ruff and mypy complain otherwise.

@DimitriPapadopoulos
Partially revert "Unused import"
4c3ea33 
This reverts commit ff13739393b2f1926b18b4019cc642f5d9ed3dafi partially.
@dstansby dstansby enabled auto-merge (squash) June 9, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs release notes Automatically applied to PRs which haven't added release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DimitriPapadopoulos @d-v-b @dstansby