simplify NDBuffer.as_scalar #3027
Merged
+8
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs release notes
This was referenced Apr 30, 2025
github-actions
bot
removed
the
needs release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wherever possible our array indexing logic should be insensitive to dtypes. There is currently some dtype-specific logic in the routine for getting scalars from size-1 numpy arrays. To fix this, this PR removes dtype-specific logic from
NDBuffer.as_scalar. Instead, it uses indexing with an empty tuple to get a numpy scalar.addresses #3026
TODO:
docs/user-guide/*.rstchanges/