Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zarr.save argument check #2446

Merged
merged 15 commits into from
Nov 5, 2024
Merged

Zarr.save argument check #2446

merged 15 commits into from
Nov 5, 2024

Conversation

brokkoli71
Copy link
Member

@brokkoli71 brokkoli71 commented Oct 30, 2024 •
edited
Loading

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

jhamman
jhamman approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@jhamman jhamman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @brokkoli71!

@jhamman jhamman merged commit d1075de into zarr-developers:main Nov 5, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAugspurger TomAugspurger TomAugspurger left review comments

@jhamman jhamman jhamman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[v3] zarr.save - AttributeError: 'str' object has no attribute 'shape'
3 participants
@brokkoli71 @TomAugspurger @jhamman