-
-
Notifications
You must be signed in to change notification settings - Fork 331
test(ci): test on windows and osx #2431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
5d24b0c
test(ci): test on windows and osx
jhamman dc113f6
add os to name
jhamman 9aeeaa1
bail on making np upper bound super flexible
jhamman 826cf0a
remove lmdb
jhamman d8ae7d6
remove types-redis
jhamman 0e542f7
fixup
jhamman df24e61
tweak timeout
jhamman e37b52f
Merge branch 'main' of https://github.com/zarr-developers/zarr-python…
jhamman cdadb53
to_posix in LocalStore
jhamman f4f74fc
no mo windows
jhamman 1e30a28
Merge branch 'main' into ci/expand-ci-matrix
jhamman df70842
Update src/zarr/storage/local.py
jhamman 85f72be
Update .github/workflows/test.yml
jhamman 30b1982
style: pre-commit fixes
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,14 +16,33 @@ concurrency: | |
|
||
jobs: | ||
test: | ||
name: py=${{ matrix.python-version }}, np=${{ matrix.numpy-version }}, deps=${{ matrix.dependency-set }} | ||
name: os=${{ matrix.os }}, py=${{ matrix.python-version }}, np=${{ matrix.numpy-version }}, deps=${{ matrix.dependency-set }} | ||
|
||
runs-on: ubuntu-latest | ||
strategy: | ||
matrix: | ||
python-version: ['3.11', '3.12', '3.13'] | ||
numpy-version: ['1.25', '1.26', '2.0'] | ||
numpy-version: ['1.25', '2.1'] | ||
dependency-set: ["minimal", "optional"] | ||
os: ["ubuntu-latest"] | ||
include: | ||
- python-version: '3.11' | ||
numpy-version: '1.25' | ||
dependency-set: 'optional' | ||
os: 'macos-latest' | ||
- python-version: '3.13' | ||
numpy-version: '2.1' | ||
dependency-set: 'optional' | ||
os: 'macos-latest' | ||
# https://github.com/zarr-developers/zarr-python/issues/2438 | ||
# - python-version: '3.11' | ||
# numpy-version: '1.25' | ||
# dependency-set: 'optional' | ||
# os: 'windows-latest' | ||
# - python-version: '3.13' | ||
# numpy-version: '2.1' | ||
# dependency-set: 'optional' | ||
# os: 'windows-latest' | ||
Comment on lines
+37
to
+44
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I've opened a dedicated ticket for this: #2438 |
||
runs-on: ${{ matrix.os }} | ||
|
||
steps: | ||
- uses: actions/checkout@v4 | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.