feature(threading): use explicit/configurable thread pool executor #2327
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, Zarr was using a home rolled
to_thread
function to offload work to an implicit executor. This PR changes this in three main ways:asyncio.to_thread
instead of the home rolled versionThreadPoolExecutor
alongside the IOthread and IOloop. The number of threads can be configured usingthreading.max_workers
.zarr.core.sync.cleanup_resources
) to explicitly cleanup resources created by Zarr at runtime. This function is executed at shutdown (viaatexit
) and can also be triggered manually (e.g. in the dask test suite)TODO: