Allow 'chunks' as an alias for 'chunk_shape' in array creation #1991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-v-b
reviewed
Jun 25, 2024
| chunk_shape = chunks | ||
| chunks = None | ||
| else: | ||
| chunk_shape = shape |
There was a problem hiding this comment.
Is this actually a good fallback? Perhaps worth bringing in guess_chunks from the v2 codebase (in a later PR).
There was a problem hiding this comment.
I agree - I was just changing one thing here.
d-v-b
approved these changes
Jun 25, 2024
dcherian
added a commit
to dcherian/zarr-python
that referenced
this pull request
Jul 25, 2024
* v3: Allow 'chunks' as an alias for 'chunk_shape' in array creation. (zarr-developers#1991)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a compatibility fix for v3.
It should fix #1965 - although I haven't tested it directly.
TODO: