Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt storage tests for changes in fsspec (#1819) (#1679) #1970

Closed
wants to merge 2 commits into from
Closed

Adapt storage tests for changes in fsspec (#1819) (#1679) #1970

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81707e5
Adapt storage tests for changes in fsspec (#1819) (#1679)
AdamWill Jun 17, 2024
fff6392
Merge branch 'main' into v2-tests-fsspec2024
dstansby Sep 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions zarr/tests/test_storage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,9 @@ def test_hierarchy(self):
assert [] == store.listdir(self.root + "c/x/y")
assert [] == store.listdir(self.root + "c/d/y")
assert [] == store.listdir(self.root + "c/d/y/z")
assert [] == store.listdir(self.root + "c/e/f")
# https://github.com/zarr-developers/zarr-python/issues/1819 and #1679
# fsspec changed from returning [] to returning ["f"] around 2024.3
assert store.listdir(self.root + "c/e/f") in ([], ["f"])

# test rename (optional)
if store.is_erasable():
Expand Down Expand Up @@ -1152,9 +1154,8 @@ def test_complex(self):
store[self.root + "foo"] = b"hello"
assert "foo" in os.listdir(str(path1) + "/" + self.root)
assert self.root + "foo" in store
assert not os.listdir(str(path2))
assert store[self.root + "foo"] == b"hello"
assert "foo" in os.listdir(str(path2))
assert store[self.root + "foo"] == b"hello"

def test_deep_ndim(self):
import zarr
Expand Down
Loading