Fix generic typing in zarr.codecs - #1845
Closed
dstansby wants to merge 1 commit into
Closed
Conversation
dstansby
force-pushed
the
code-any-generics
branch
2 times, most recently
from
May 10, 2024 09:31
2a4e1d4 to
7f50621
Compare
dstansby
force-pushed
the
code-any-generics
branch
from
May 10, 2024 15:38
7f50621 to
a25bad6
Compare
dstansby
marked this pull request as ready for review
May 10, 2024 15:48
Member
|
Hi David, thanks for working on this. I think it is important to get extensive mypy coverage in the 3.0 release. |
Contributor
Author
|
No worries, thanks for letting me know - shall we close this PR then? |
Member
|
Yeah. I guess that makes sense. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This finishes typing generic types in
zarr.codecs. There's still one issue that needs fixing...TODO: