Bump Numpy required version to 1.20 #1192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitriPapadopoulos
changed the title
|
Perhaps test against the oldest supported version instead of / in addition to the latest version: zarr-python/requirements_dev_numpy.txt Lines 1 to 4 in 4362bb4 |
jakirkham
reviewed
Oct 18, 2022
We use the named parameter `shape` of `numpy.empty_like`: https://github.com/zarr-developers/zarr-python/blob/4362bb4/zarr/hierarchy.py#L145 https://github.com/zarr-developers/zarr-python/blob/4362bb4/zarr/core.py#L2134-L2135 It had been introduced in Numpy 1.17.0: https://numpy.org/doc/stable/reference/generated/numpy.empty_like.html According to NEP 29, NumPy 1.20+ is currently supported: https://numpy.org/neps/nep-0029-deprecation_policy.html
DimitriPapadopoulos
force-pushed
the
numpy.empty_like_shape
branch
from
f1e3613 to
f13ed21
Compare
DimitriPapadopoulos
changed the title
jakirkham
approved these changes
Oct 18, 2022
|
Thanks Dimitri! 🙏 Merging once CI passes 😄 |
Codecov Report
@@ Coverage Diff @@
## main #1192 +/- ##
=======================================
Coverage 99.99% 99.99%
=======================================
Files 35 35
Lines 14135 14136 +1
=======================================
+ Hits 14134 14135 +1
Misses 1 1
|
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use the named parameter
shapeofnumpy.empty_like:It had been introduced in Numpy 1.17.0:
https://numpy.org/doc/stable/reference/generated/numpy.empty_like.html
According to NEP 29, NumPy 1.20+ is currently supported:
https://numpy.org/neps/nep-0029-deprecation_policy.html
TODO: