Remove/relax erroneous "meta" path check #1123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this avoids disallowing key names such as 'metabolite', for instance
|
@joshmoore, this seems relatively high priority to get in for v2.13 as it was a regression in behavior for Zarr v2 arrays introduced in 2.12. |
Codecov Report
@@ Coverage Diff @@
## main #1123 +/- ##
=======================================
Coverage 99.94% 99.94%
=======================================
Files 35 35
Lines 13965 13967 +2
=======================================
+ Hits 13958 13960 +2
Misses 7 7
|
|
I will try this version on our files later today or tomorrow and let you know. |
|
@grlee77 it is working on our datasets that have a "metadata" group now 👍🏻 |
|
Thanks, @tasansal. I've added a test (that fails without this PR) and will get this into a pre-release this morning. I'll follow up with 2.13.0 ASAP. |
|
Oddly, the test I added here is failing on conda-forge: conda-forge/zarr-feedstock#65 cc: @jakirkham |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Description of PR]
resolves #1105
This PR removes the check disallowing keys starting with "meta" from the Zarr v2 code path. It was not there previously and appears to have been accidentally introduced along with the preliminary v3 support.
For v3, the check is updated to disallow starting with "meta/" instead of "meta" for consistency with
StoreV3._validate_key(used by the__setitem__method of various v3 store classes).TODO:
* [ ] Add docstrings and API docs for any new/modified user-facing classes and functions* [ ] New/modified features documented in docs/tutorial.rst