Skip to content

drop py37 #1067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 11, 2022
Merged

drop py37 #1067

merged 3 commits into from
Jul 11, 2022

Conversation

d-v-b
Copy link
Contributor

@d-v-b d-v-b commented Jul 5, 2022

Drop python 3.7

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@joshmoore joshmoore mentioned this pull request Jul 6, 2022
6 tasks
@joshmoore
Copy link
Member

@d-v-b, after merging #988, I attempted to fix the conflicts. This resurrected the minimum numpy dependency tests. Perhaps a discussion is needed with @madsbk in terms of the necessity of that.

Copy link
Contributor

@madsbk madsbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakirkham
Copy link
Member

IIUC Python 3.7 is also dropped in NEP 29 as of late last year. So this goes along with the NumPy update.

@jakirkham
Copy link
Member

cc @rabernat (in case you have thoughts 🙂)

@joshmoore
Copy link
Member

@d-v-b: anything else from your side?

@d-v-b
Copy link
Contributor Author

d-v-b commented Jul 8, 2022

i dont think theres anything else to do :)

@joshmoore
Copy link
Member

i dont think theres anything else to do :)

😄 awesome and ergo you're happy with my changes.

@joshmoore
Copy link
Member

Merging in preparation for the 2.13.x series.

@joshmoore joshmoore merged commit 9ce2f32 into zarr-developers:main Jul 11, 2022
@d-v-b d-v-b deleted the drop_py37 branch December 21, 2022 15:15
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.94%. Comparing base (611afad) to head (4659b3a).
Report is 357 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1067   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files          34       34           
  Lines       13846    13846           
=======================================
  Hits        13839    13839           
  Misses          7        7           
Files Coverage Δ
setup.py 0.00% <ø> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants