Pre-commit configuration #1015
Merged
Pre-commit configuration #1015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Alt-Shivam. Thanks for starting this. Can you also add a .github/workflows change that executes the pre-commit so that we know it's working? |
|
Added. @joshmoore |
|
From the build log: 🎉 |
joshmoore
approved these changes
Apr 29, 2022
There was a problem hiding this comment.
Thanks, @Alt-Shivam! I'll not that we probably want to move to https://github.com/marketplace/pre-commit-ci rather than have our workflow, but for the moment, while we're investigating, 👍 for having this in place.
|
Cheers @joshmoore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Description of PR]
Flake8 is already added.
and the following will be added soon.
With few changes
https://github.com/pre-commit/mirrors-mypy
https://github.com/adrienverge/yamllint.git
https://github.com/asottile/pyupgrade
With moderate changes
https://github.com/pre-commit/pre-commit-hooks
https://github.com/asottile/seed-isort-config
https://github.com/PyCQA/isort
With lots of changes
https://github.com/psf/black