Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ShardingCodec cannot be pickled #1990

Closed
d-v-b opened this issue Jun 25, 2024 · 0 comments · Fixed by #2011
Closed

ShardingCodec cannot be pickled #1990

d-v-b opened this issue Jun 25, 2024 · 0 comments · Fixed by #2011
Labels
help wanted Issue could use help from someone with familiarity on the topic V3 Affects the v3 branch

Comments

@d-v-b
Copy link
Contributor

d-v-b commented Jun 25, 2024

Because it uses lru_cache and we have not implemented the requisite dunder methods for object serialization to make it pickleable, which is not hard according to internet wisdom .

todo:

  • add tests for pickleability for the ingredients of Array and Group classes
  • implement __getstate__ and __setstate__ as needed to make failing tests pass
@d-v-b d-v-b added V3 Affects the v3 branch help wanted Issue could use help from someone with familiarity on the topic labels Jun 25, 2024
@d-v-b d-v-b mentioned this issue Jul 3, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Issue could use help from someone with familiarity on the topic V3 Affects the v3 branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make shardingcodec pickleable d-v-b/zarr-python
1 participant
@d-v-b