Closed
Description
I thought I'd open an issue to track the path to adding 100% typing to the v3 branch. The mypy docs have a good guide to gradually adding typing to existing code, and from there I think the best way to get to enabling the mypy
strict option is work through the sub-options that make up the strict rule:
- warn_unused_configs = True Remove unused typing ignore comments #1781
- warn_redundant_casts = True Remove unused typing ignore comments #1781
- warn_unused_ignores = True Remove unused typing ignore comments #1781
- strict_equality = True [v3] Enable some more strict mypy options #1793
- strict_concatenate = True [v3] Enable some more strict mypy options #1793
- check_untyped_defs = True Check untyped defs on v3 #1784, [v3] Fix some untyped defs #1790
- disallow_subclassing_any = True
- disallow_untyped_decorators = True [v3] Enable some more strict mypy options #1793
- disallow_any_generics = True [v3] Disallow generic Any typing #1794
- disallow_untyped_calls = True Disallow untyped calls #1811
- disallow_incomplete_defs = True Disallow incomplete type definitions #1814
- disallow_untyped_defs = True Disallow untyped defs #1834
- no_implicit_reexport = True Disallow implicit re-exports #1908
- warn_return_any = True
From repo-review
- warn_unreachable = True Enable warn_unreachable for mypy #1937
- enable_error_code = ["ignore-without-code", "redundant-expr", "truthy-bool"] Enable extra mypy error codes #1909
We can use the list above to track progress, and link pull requests that address each option in turn (from top to bottom).
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Status
Done