Skip to content

Add #ifndef guard around PyBytes_RESIZE #732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 9, 2025

Conversation

jakirkham
Copy link
Member

Ensure PyBytes_RESIZE is not accidentally redefined by placing it inside an #ifndef/#endif guard block.


TODO:

  • Unit tests and/or doctests in docstrings
  • Tests pass locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • Docs build locally
  • GitHub Actions CI passes
  • Test coverage to 100% (Codecov passes)

Copy link

codecov bot commented Apr 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (933d901) to head (16546f5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #732   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files          63       63           
  Lines        2738     2738           
=======================================
  Hits         2737     2737           
  Misses          1        1           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jakirkham jakirkham merged commit 58bc9c4 into zarr-developers:main Apr 9, 2025
30 checks passed
@jakirkham jakirkham deleted the add_ifndef_PyBytes_RESIZE branch April 9, 2025 00:38
@jakirkham
Copy link
Member Author

Putting in this minor fix to guard against potential compilation errors (none seen yet though)

Runtime usage is unaffected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant