Netcdf4 fix #116
Merged
Netcdf4 fix #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
norlandrhagen
commented
May 15, 2024
•
norlandrhagen
commented
- fixes Inline loaded variables into kerchunk references #73 (comment)
TomNicholas
added a commit
that referenced
this pull request
May 16, 2024
* add test vs kerchunk inlining * encode inlined data correctly (at least for standard numpy arrays) * don't test time variable for now * store fill_value as np.NaN, and always coerce it * test passing for lat and lon variables * formatting * encode numpy types * tidy internal import * parametrize test to test inlining different variables * raise when encoding encountered during serialization of numpy arrays * see if closing the netcdf files in the fixtures fixes the kerchunk error * update docs * ensure inline_threshold is an int * formatting * specified NetCDF4 for netcdf4_file fixture & added netcdf4 to pyproject.toml [test] (#116) * organize tests * dont unnecessarily slice dataset --------- Co-authored-by: Raphael Hagen <norlandrhagen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.