Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to type hint new StringDType #151

Open
TomNicholas opened this issue Jun 21, 2024 · 1 comment
Open

Unable to type hint new StringDType #151

TomNicholas opened this issue Jun 21, 2024 · 1 comment
Labels
bug Something isn't working typing upstream issue

Comments

@TomNicholas
Copy link
Member

In #107 we now use the new numpy variable-length StringDType to store paths in-memory in the Manifest, but I had to ignore some typing errors to satisfy mypy. Turns out this is an upstream issue (numpy/numpy#26747). I actually don't really understand what they're talking about in that issue, but once there is a clear recommendation we can remove the type: ignores here.

@TomNicholas TomNicholas added bug Something isn't working upstream issue labels Jun 21, 2024
@TomNicholas
Copy link
Member Author

I think this is fixed - #252 seems to work at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working typing upstream issue
Projects
None yet
Development

No branches or pull requests

1 participant