Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mypy errors around numpy functions not being strictly type hinted #252

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

TomNicholas
Copy link
Member

Hoping this fixes some of the typing errors @norlandrhagen flagged in #249

@TomNicholas
Copy link
Member Author

TomNicholas commented Oct 11, 2024

Hoping this fixes some of the typing errors

This does seem to work, but would be easier to see if mypy ran in a separate CI job (#253)

No idea what's going on with the hdf5 dependency in the docs build

@norlandrhagen
Copy link
Collaborator

norlandrhagen commented Oct 11, 2024

No idea what's going on with the hdf5 dependency in the docs build

For building the docs, do we need all the deps in the -e "..[test]" line?

@TomNicholas
Copy link
Member Author

For building the docs, do we need all the deps in the - -e "..[test]" line?

The docs don't actually dynamically run any examples (see #83), so almost certainly we don't.

@TomNicholas
Copy link
Member Author

This passes the new separate test so should be good to merge?

@norlandrhagen norlandrhagen merged commit 2d66e88 into main Oct 11, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants