Skip to content

fix(proxy): support for system CA with mTLS certs#5074

Queued
brandtkeller wants to merge 1 commit into
mainfrom
proxy_mode_mtls_system
Queued

fix(proxy): support for system CA with mTLS certs#5074
brandtkeller wants to merge 1 commit into
mainfrom
proxy_mode_mtls_system

Conversation

@brandtkeller

@brandtkeller brandtkeller commented Jul 14, 2026

Copy link
Copy Markdown
Member

Description

The use of the proxy registry mode (which notably added mTLS certs to the registry/proxy) enabled encryption of the image push logic - but when the registry is backed by an s3 storage backend and not configured to disable redirects uses the self-signed CA to perform the redirect to the S3 bucket and fails due to TLS handshake.

This adds the self signed CA to the system CA instead of solely creating a new cert pool.

Worth noting that this can be overcome by setting configuration on the registry to disable redirects and have the registry route all traffic.

Related Issue

Fixes #5075

Checklist before merging

Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
@netlify

netlify Bot commented Jul 14, 2026

Copy link
Copy Markdown

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 1ecf618
🔍 Latest deploy log https://app.netlify.com/projects/zarf-docs/deploys/6a56b8181f27c70008d58347

@brandtkeller brandtkeller marked this pull request as ready for review July 15, 2026 02:38
@brandtkeller brandtkeller requested review from a team as code owners July 15, 2026 02:38
@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/pkg/pki/pki.go 40.00% 4 Missing and 2 partials ⚠️
Files with missing lines Coverage Δ
src/pkg/pki/pki.go 60.67% <40.00%> (-0.96%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AustinAbro321 AustinAbro321 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes perfect sense as a fix, nice work

@brandtkeller brandtkeller added this pull request to the merge queue Jul 15, 2026
Any commits made after this event will not be merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

S3-backed registry in proxy mode fails image push with x509 error on redirect for existing blobs

2 participants