Skip to content

Conversation

@AustinAbro321
Copy link
Member

@AustinAbro321 AustinAbro321 commented Dec 18, 2025

Description

This fixes a bug with the registry proxy solution, where it does not work with flux and helm repo objects since the clusterip / hostname of the service is not added to the secret and was not returned.

Related Issue

Fixes #4474

Checklist before merging

Signed-off-by: Austin Abro <austinabro321@gmail.com>
@netlify
Copy link

netlify bot commented Dec 18, 2025

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 951fc84
🔍 Latest deploy log https://app.netlify.com/projects/zarf-docs/deploys/695d33727c126800086c4621

@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

❌ Patch coverage is 40.00000% with 27 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/pkg/cluster/secrets.go 35.71% 25 Missing and 2 partials ⚠️
Files with missing lines Coverage Δ
src/internal/agent/hooks/flux-helmrepo.go 77.50% <100.00%> (ø)
src/internal/agent/hooks/flux-ocirepo.go 85.12% <100.00%> (+2.47%) ⬆️
src/pkg/cluster/tunnel.go 9.22% <ø> (ø)
src/pkg/transform/image.go 94.82% <100.00%> (ø)
src/pkg/cluster/secrets.go 54.81% <35.71%> (-8.58%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

AustinAbro321 and others added 5 commits December 18, 2025 10:52
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
@AustinAbro321 AustinAbro321 marked this pull request as ready for review January 6, 2026 13:28
@AustinAbro321 AustinAbro321 requested review from a team as code owners January 6, 2026 13:28
@AustinAbro321 AustinAbro321 moved this to PR Review in Zarf Jan 6, 2026
@AustinAbro321 AustinAbro321 marked this pull request as draft January 6, 2026 13:42
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
@AustinAbro321 AustinAbro321 marked this pull request as ready for review January 6, 2026 16:29
Copy link
Contributor

@a1994sc a1994sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one follow up comment for a different PR

@AustinAbro321 AustinAbro321 added this pull request to the merge queue Jan 7, 2026
Merged via the queue into main with commit 8f9f5f2 Jan 7, 2026
30 checks passed
@AustinAbro321 AustinAbro321 deleted the fix-registry-mutation-registry-proxy branch January 7, 2026 18:09
@github-project-automation github-project-automation bot moved this from PR Review to Done in Zarf Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

When using [alpha] feature registry-mode, OCIRepo resource not properly mutated to intra-cluster endpoint

3 participants