Skip to content

Conversation

@robinlieb
Copy link
Contributor

Description

Adds functionality to patch repoURL for Argo CD ApplicationSets.

This only adds patching of the git URL for the generations section, not in the template section of the ApplicationSet. This will be patches by the Argo CD Application itself.

Related Issue

Relates to #2955

Checklist before merging

@robinlieb robinlieb requested review from a team as code owners November 6, 2025 19:19
@netlify
Copy link

netlify bot commented Nov 6, 2025

Deploy Preview for zarf-docs ready!

Name Link
🔨 Latest commit fd58c2a
🔍 Latest deploy log https://app.netlify.com/projects/zarf-docs/deploys/695bc8c2e8812800080cf53d
😎 Deploy Preview https://deploy-preview-4348--zarf-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@robinlieb robinlieb force-pushed the feat/argocd-applicationsets branch 2 times, most recently from b32e7b5 to b5395cb Compare November 13, 2025 18:59
@brandtkeller brandtkeller moved this to PR Review in Zarf Dec 4, 2025
@robinlieb robinlieb force-pushed the feat/argocd-applicationsets branch from b5395cb to 7a444d3 Compare December 7, 2025 07:42
@codecov
Copy link

codecov bot commented Dec 16, 2025

Codecov Report

❌ Patch coverage is 71.79487% with 11 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/internal/agent/hooks/argocd-applicationset.go 75.67% 7 Missing and 2 partials ⚠️
src/internal/agent/start.go 0.00% 2 Missing ⚠️
Files with missing lines Coverage Δ
src/internal/agent/start.go 0.00% <0.00%> (ø)
src/internal/agent/hooks/argocd-applicationset.go 75.67% <75.67%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AustinAbro321
Copy link
Member

Hi @robinlieb thanks for the PR, and sorry for the delays in reviewing this. Generally we like to see the Zarf agent functionality tested in an end to end way. It helps us ensure that there are no regressions in the mutating web hook, and that the mutated resources work in a cluster as expected. Could you add an application set to the argocd package in examples? With how our test suite is currently structured, this will sufficiently test the webhook.

Also we should add a quick line modification to the argocd line in the init package docs that adds Argocd Application Sets

@robinlieb
Copy link
Contributor Author

Thanks for the feedback, will update the PR with a useful example for the Argo CD Application set in the Argo CD example and update the init package docs.

Signed-off-by: Robin Lieb <34332703+robinlieb@users.noreply.github.com>
Signed-off-by: Robin Lieb <34332703+robinlieb@users.noreply.github.com>
@robinlieb robinlieb force-pushed the feat/argocd-applicationsets branch from 7a444d3 to 54c16d9 Compare December 19, 2025 17:17
@robinlieb
Copy link
Contributor Author

Example and docs added.

Copy link
Member

@AustinAbro321 AustinAbro321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work adding an example, a few notes on it

valuesFiles:
- applicationset/values.yaml
repos:
- https://github.com/argoproj/argo-cd.git
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- https://github.com/argoproj/argo-cd.git
- https://github.com/argoproj/argo-cd.git@v3.2.2

I noticed that this takes quite a while to download. It's a big repo, but it's taking me about 3 minutes to pull it, much longer than I'd expect with >500mbs. Likely something we'll want to look into. For now, I think it's pragmatic to pull a specific tag, as we want this to be faster for users trying out examples, and for our test suite

Comment on lines +67 to +72
wait:
cluster:
kind: Application
name: argo-workflows
namespace: argocd
condition: exists
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should instead wait for the deployment or pod as we do in the other argo chart. The argo workflows are part of the helm chart, so those will already be waited on by Zarf / Helm normally. Since the pods / deployments happen outside of the scope of the Helm chart, Zarf won't wait for them normally and we want custom waits.

@github-project-automation github-project-automation bot moved this from PR Review to In progress in Zarf Jan 5, 2026
@AustinAbro321 AustinAbro321 mentioned this pull request Jan 5, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

2 participants