-
Notifications
You must be signed in to change notification settings - Fork 226
feat: add support for Argo CD ApplicationSets #4348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for zarf-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
b32e7b5 to
b5395cb
Compare
b5395cb to
7a444d3
Compare
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
|
Hi @robinlieb thanks for the PR, and sorry for the delays in reviewing this. Generally we like to see the Zarf agent functionality tested in an end to end way. It helps us ensure that there are no regressions in the mutating web hook, and that the mutated resources work in a cluster as expected. Could you add an application set to the argocd package in examples? With how our test suite is currently structured, this will sufficiently test the webhook. Also we should add a quick line modification to the argocd line in the init package docs that adds Argocd Application Sets |
|
Thanks for the feedback, will update the PR with a useful example for the Argo CD Application set in the Argo CD example and update the init package docs. |
Signed-off-by: Robin Lieb <34332703+robinlieb@users.noreply.github.com>
Signed-off-by: Robin Lieb <34332703+robinlieb@users.noreply.github.com>
7a444d3 to
54c16d9
Compare
|
Example and docs added. |
AustinAbro321
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work adding an example, a few notes on it
| valuesFiles: | ||
| - applicationset/values.yaml | ||
| repos: | ||
| - https://github.com/argoproj/argo-cd.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - https://github.com/argoproj/argo-cd.git | |
| - https://github.com/argoproj/argo-cd.git@v3.2.2 |
I noticed that this takes quite a while to download. It's a big repo, but it's taking me about 3 minutes to pull it, much longer than I'd expect with >500mbs. Likely something we'll want to look into. For now, I think it's pragmatic to pull a specific tag, as we want this to be faster for users trying out examples, and for our test suite
| wait: | ||
| cluster: | ||
| kind: Application | ||
| name: argo-workflows | ||
| namespace: argocd | ||
| condition: exists |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should instead wait for the deployment or pod as we do in the other argo chart. The argo workflows are part of the helm chart, so those will already be waited on by Zarf / Helm normally. Since the pods / deployments happen outside of the scope of the Helm chart, Zarf won't wait for them normally and we want custom waits.
Description
Adds functionality to patch repoURL for Argo CD ApplicationSets.
This only adds patching of the git URL for the generations section, not in the template section of the ApplicationSet. This will be patches by the Argo CD Application itself.
Related Issue
Relates to #2955
Checklist before merging