Skip to content

Conversation

brandtkeller
Copy link
Member

@brandtkeller brandtkeller commented Sep 19, 2025

Description

Resolves the issue of goreleaser force push on the nightly tag making the latest tag resolve to nightly instead of the latest semver.

The Set CLI_VERSION step of the nightly release fetches the latest git tag and processes the semver to produce a mirror of what goreleaser is expecting (IE current latest semver + increment the patch integer). This was failing on the initial nightly releases after the nightly tag was the latest.

Example: https://github.com/zarf-dev/zarf/pkgs/container/packages%2Finit/518897335?tag=nightly0.0.1-nightly

This looks to be resolved as of the latest release v0.62.0 - but determined the problem to be with the latest tag. If we ignore any non-semver tags and preleases then this logic is more deterministic. This will aid other OpenSSF projects that might wish to have an example to pull from for this workflow.

Related Issue

Relates to #3928

Checklist before merging

Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
@brandtkeller brandtkeller requested review from a team as code owners September 19, 2025 21:46
Copy link

netlify bot commented Sep 19, 2025

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit e940c97
🔍 Latest deploy log https://app.netlify.com/projects/zarf-docs/deploys/68d6af0a38e63000083f4eb8

Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
Copy link

codecov bot commented Sep 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@brandtkeller brandtkeller self-assigned this Sep 20, 2025
@AustinAbro321
Copy link
Contributor

@brandtkeller Could you explain further the problem that this PR solves or create an issue for it

@brandtkeller
Copy link
Member Author

@AustinAbro321 Added to the description - this is a non-critical but minor fix to the logic with largely the aspiration to serve as an initial model for other golang OpenSSF projects to emulate.

@brandtkeller brandtkeller added this pull request to the merge queue Sep 26, 2025
Merged via the queue into main with commit d7c0150 Sep 26, 2025
27 checks passed
@brandtkeller brandtkeller deleted the fix_nightly_version_step branch September 26, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants