Skip to content

Conversation

AustinAbro321
Copy link
Contributor

@AustinAbro321 AustinAbro321 commented May 9, 2025

Description

In #3767 we created a generic cache for ORAS layers. This is used by default, but we also have a special implementation of caching specifically for skeleton packages. This PR removes that implementation so only the generic cache is used. By doing this we get closer to enabling the ability for users to turn off the cache.

Checklist before merging

Copy link

netlify bot commented May 9, 2025

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 22aba94
🔍 Latest deploy log https://app.netlify.com/projects/zarf-docs/deploys/68dd24782900d70008565ce6

Copy link

codecov bot commented May 9, 2025

Codecov Report

❌ Patch coverage is 10.00000% with 9 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/pkg/packager/load/import.go 10.00% 9 Missing ⚠️
Files with missing lines Coverage Δ
src/pkg/packager/load/import.go 51.30% <10.00%> (+0.13%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@AustinAbro321 AustinAbro321 force-pushed the use-oci-cache-for-skeleton-packages branch from aabfa4b to e641e4c Compare May 9, 2025 20:26
@AustinAbro321 AustinAbro321 marked this pull request as ready for review May 9, 2025 20:34
@AustinAbro321 AustinAbro321 requested review from a team as code owners May 9, 2025 20:34
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@AustinAbro321 AustinAbro321 marked this pull request as draft May 9, 2025 20:38
AustinAbro321 and others added 8 commits May 12, 2025 12:33
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant