Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: transform set variables to uppercase in dev inspect definition #3428

Merged
merged 3 commits into from
Jan 23, 2025
Merged

fix: transform set variables to uppercase in dev inspect definition #3428

merged 3 commits into from
Jan 23, 2025

Conversation

AustinAbro321
Copy link
Contributor

@AustinAbro321 AustinAbro321 commented Jan 23, 2025 •
edited
Loading

Description

Fixes a bug where user variables were not getting transformed to uppercase.

Checklist before merging

@AustinAbro321
fix set variable input
da083b6 
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@AustinAbro321 AustinAbro321 requested review from a team as code owners January 23, 2025 15:38
@netlify Netlify
Copy link

netlify bot commented Jan 23, 2025 •
edited
Loading

✅ Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit e7069ff
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/679273d6508a49000843f807

@codecov Codecov
Copy link

codecov bot commented Jan 23, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/cmd/dev.go 0.00% 3 Missing ⚠️
Files with missing lines Coverage Δ
src/cmd/dev.go 0.00% <0.00%> (ø)

@AustinAbro321
merge maps
1261a12 
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
mkcp
mkcp previously approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@mkcp mkcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AustinAbro321
don't use global state
e7069ff 
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@AustinAbro321 AustinAbro321 added this pull request to the merge queue Jan 23, 2025
Merged via the queue into main with commit 2cbd0f1 Jan 23, 2025
26 checks passed
@AustinAbro321 AustinAbro321 deleted the fix-set-variables-to-upper branch January 23, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkcp mkcp mkcp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AustinAbro321 @mkcp