feat(command): implement duplicate statement command #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
December 13, 2022 00:13
Owner
|
Refactoring? Im good with this, but will add JSON tests to ensure doesn't break anything |
Owner
|
Not copy, change to duplicate as in linked issue |
Ilanaya
changed the title
Owner
Or you can try to adopt JSON integration tests from https://github.com/zardoy/vscode-fix-all-json/tree/main/test/integration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2
I think I've managed to preserve
moveStatementfunctionality with all these refactorings.Copying up/down works well in single-selection cases, but I have trouble making it work with multi-cursor. So, I'll set it on draft until I manage how to fix it.