goreleaser: fix homebrew test case #836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmeneg
force-pushed
the
fix-homebrew
branch
2 times, most recently
from
bd8d90b to
60c3a63
Compare
On previous commits lab stopped to wrap git commands, thus the homebrew test needed to be fixed in the point where a call to `lab ls-files` was being made. At the same time, the whole test doesn't make sense considering lab wasn't really being used. So, instead of only fixing the `ls-files` portion, this patch is changing the test to only check the lab version. Signed-off-by: Bruno Meneguele <bmeneg@redhat.com>
Codecov Report
@@ Coverage Diff @@
## master #836 +/- ##
=======================================
Coverage 55.94% 55.94%
=======================================
Files 77 77
Lines 5750 5750
=======================================
Hits 3217 3217
Misses 2243 2243
Partials 290 290 Continue to review full report at Codecov.
|
zampierilucas
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On previous commits lab stopped to wrap git commands, thus the homebrew
test needed to be fixed in the point where a call to
lab ls-fileswasbeing made. At the same time, the whole test doesn't make sense
considering lab wasn't really being used. So, instead of only fixing the
ls-filesportion, this patch is changing the test to only check thelab version.
Signed-off-by: Bruno Meneguele bmeneg@redhat.com
Fixes #833.