Skip to content

editor starts on non-editing commands #790

Closed
@prarit

Description

@prarit

@bmeneg, commit 66c580f ("cmd/edit: accept linebreak flag for editing description") significantly changed the behavior of the 'lab mr edit' command. Previous to this commit, 'lab mr edit --ready' or 'lab mr edit --draft' or 'lab mr edit --reviewer' would not open up an editor.

After the commit, the editor ALWAYS opens. This code likely should not have been removed:

-       // if other flags were given (eg label), then skip the editor and return
-       // what we already have
-       if nFlag != 0 {
-               return title, body, nil
-       }
-

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions