Open
Conversation
psiinon
force-pushed
the
httpsInfo/reboot
branch
from
7d19b15 to
61db2a9
Compare
Member
Author
|
New Issues (8)Checkmarx found the following issues in this Pull Request
Use @Checkmarx to interact with Checkmarx PR Assistant. |
psiinon
force-pushed
the
httpsInfo/reboot
branch
2 times, most recently
from
0b6d411 to
6e5f25f
Compare
Signed-off-by: Simon Bennetts <psiinon@gmail.com>
psiinon
force-pushed
the
httpsInfo/reboot
branch
from
6e5f25f to
4498e51
Compare
kingthorin
reviewed
Mar 12, 2026
| private static final List<Class<? extends Extension>> DEPENDENCIES; | ||
|
|
||
| static { | ||
| List<Class<? extends Extension>> dep = new ArrayList<>(1); |
Member
There was a problem hiding this comment.
2 when instantiating since we know there are two entries
Or actually can this all be inlined with List.of ?
Comment on lines
+393
to
+396
| sb.append(Constant.messages.getString("httpsinfo.general.cert.self.signed")) | ||
| .append(' ') | ||
| .append(cert.isSelfSignedCertificate()) | ||
| .append(newline); |
Member
There was a problem hiding this comment.
Instead of all these doing appends wouldn't it be simpler if they just used substitution? (To insert the values into the resource messages)
Member
There was a problem hiding this comment.
I see now that this followed the original model of the panel output.
I still think substitution is probably the better choice but I understand if you want to keep it as-is for now.
Member
There was a problem hiding this comment.
Does this need a weight to be sorted/placed correctly?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
I've left the original file copyright dates but can change them if thats better.