-
-
Notifications
You must be signed in to change notification settings - Fork 14
Added dark theme support in style.scss: improves contrast and readability #227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
New Issues (2)Checkmarx found the following issues in this Pull Request
|
Works well on Chrome 😁 |
Hi @psiinon , |
Is Firefox set to dark or to system? (I haven't tested but perhaps that's handled differently?) |
Hi @kingthorin , |
That could definitely be the difference - I've set Firefox to "Dark" rather than "Automatic" (which uses the system). |
I'll try to pull and build this today and test it in both scenarios. @Yogi-Codes for the DCO you'll need to sign-off on all commits. https://git-scm.com/docs/git-commit#Documentation/git-commit.txt---signoff I'd suggest just squashing it all into one and signing that one off, we general prefer single commit PRs anyway. (Yes that means forced pushing) |
1952c11
to
abd4541
Compare
Hi @kingthorin . |
abd4541
to
54811cd
Compare
It can wait till the end or we can also do it at merge I believe. |
sure , |
Okay I managed to do some local testing with Firefox on Windows. There are actually two settings "Website Appearance" and "Theme". However, in all combinations it seemed to behave in an expected way for me. Tried both the full extension and recorder. |
That's great , Thanks for testing |
The contrast between the background and the ZAP icon label is still poor (IMHO), lighter darker would be better, or change the icon label. |
Hi , |
544311e
to
784b621
Compare
I've just pushed an update which changes the ZAP icon with Checkmarx in white which is just used in dark mode. |
5d8436f
to
198ec15
Compare
readability Signed-off-by: Yogi-Codes <yogicodes101@gmail.com>
198ec15
to
f4f465b
Compare
Thank you both! |
This PR adds dark theme support to the
zaproxy/browser-extension
.Changes Made:
style.scss
to define custom dark mode colorsFixes:
Fixes #225