Skip to content

Commit

Permalink
fix(cli): Remove logic converting empty array to undefined in changel…
Browse files Browse the repository at this point in the history
…og metadata (#690)

* remove problematic array to undefined logic

* remove changelog text used for testing

* update truthy checks of metadata

* change fix approach

* fix join statement
  • Loading branch information
kreddlear authored Aug 28, 2023
1 parent 936f3e5 commit e0afe65
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions packages/cli/src/oclif/commands/promote.js
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,8 @@ ${metadataPromptHelper}`);
if (appFeatureUpdates || issueFeatureUpdates) {
this.log(
`Feature updates: ${[
...appFeatureUpdates,
...issueFeatureUpdates,
...(appFeatureUpdates ?? []),
...(issueFeatureUpdates ?? []),
].join(', ')}`
);
}
Expand All @@ -114,7 +114,11 @@ ${metadataPromptHelper}`);
.map(({ issue_id }) => `#${issue_id}`);

if (appBugfixes || issueBugfixes) {
this.log(`Bug fixes: ${[...appBugfixes, issueBugfixes].join(', ')}`);
this.log(
`Bug fixes: ${[...(appBugfixes ?? []), ...(issueBugfixes ?? [])].join(
', '
)}`
);
}

if (
Expand Down

0 comments on commit e0afe65

Please sign in to comment.