Have getLatestPipelineID return branch pipeline ID if no merge request pipeline was found
#36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o no merge request pipelines configured Signed-off-by: Alec Hinh <alec.hinh@zapier.com>
Signed-off-by: Alec Hinh <alec.hinh@zapier.com>
djeebus
approved these changes
Aug 16, 2023
|
seems like a reasonable fall back to me, I'm on board |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #33
Proposed Changes
getLatestPipelineIDto return a nonmerge_request_eventCI pipeline ID if no merge request pipelines were found, rather than just returningnilif no MR pipelines were foundTesting Information
Tested this via localdev environment
Before behavior
After change
Other information
While I still haven't found the root cause of why the full polling task retries multiple times when
getLatestPipelineIDalways returnsnildue to a repo not having an MR pipeline configured, this will at least stop the retry behavior which should save us from spending unnecessary compute cycles waiting to get a non existant pipeline ID, and spamming an MR with the same comment over and over again.Note that this issue and logic only appears on Gitlab. Github does not have this issue.