Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add parameter to pass targets back to TFRunner #27

Merged
merged 2 commits into from
May 1, 2023
Merged

add parameter to pass targets back to TFRunner #27

merged 2 commits into from
May 1, 2023

Conversation

mplachter
Copy link
Collaborator

Add the ability to pass targets back with -t or --targets flag for runner

https://cdn.zappy.app/e47c99793539c58b1b65c8d152535ae4.gif

@mplachter
add parameter to pass targets back to TFRunner
1f01f19 
Signed-off-by: Matt Plachter <matthew.plachter@zapier.com>
@mplachter mplachter marked this pull request as ready for review May 1, 2023 22:01
sl1pm4t
sl1pm4t suggested changes May 1, 2023
View reviewed changes
Copy link
Contributor

@sl1pm4t sl1pm4t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to make sure we are not setting a successful pipeline status for targeted runs, otherwise unapplied changes could be merged.

@mplachter
make it that a full workspace apply needs to be ran before check passed
0af7ac4 
Signed-off-by: Matt Plachter <matthew.plachter@zapier.com>
@mplachter
Copy link
Collaborator Author

We need to make sure we are not setting a successful pipeline status for targeted runs, otherwise unapplied changes could be merged.

Good catch the status will still be pending until a full apply or workspace apply has be ran.
Also when targets are passed the comments will have instructions to run a full apply.

@sl1pm4t sl1pm4t merged commit 2698e69 into main May 1, 2023
@sl1pm4t sl1pm4t deleted the add-targets-to-tfbuddy branch May 1, 2023 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sl1pm4t sl1pm4t sl1pm4t approved these changes

@davidwin93 davidwin93 Awaiting requested review from davidwin93

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mplachter @sl1pm4t