Add Basic OTEL Tracing to TFBuddy #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mplachter
force-pushed
the
add-opentelemetry-tracing
branch
from
fe33056
to
9b834f5
Compare
|
@sl1pm4t @davidwin93 if i fix this merge request is this good to merge? |
davidwin93
reviewed
Aug 4, 2023
cmd/root.go
Outdated
| Version: pkg.GitTag, | ||
| CommitSHA: pkg.GitCommit, | ||
| } | ||
| fmt.Printf("enabled: %v\thost: %s\tport: %s\n", enableOtel, otelHost, otelPort) |
There was a problem hiding this comment.
instead of fmt could these use log
|
If you resolve the merge conflicts I think this would be good to merge. Solid work! |
mplachter
force-pushed
the
add-opentelemetry-tracing
branch
from
9b834f5
to
2adff47
Compare
Signed-off-by: Matt Plachter <matthew.plachter@zapier.com>
mplachter
force-pushed
the
add-opentelemetry-tracing
branch
from
2adff47
to
0b187ce
Compare
Signed-off-by: Matt Plachter <matthew.plachter@zapier.com>
davidwin93
requested changes
Aug 16, 2023
pkg/gitlab_hooks/hook_worker.go
Outdated
| @@ -39,14 +40,17 @@ func NewGitlabEventWorker(h *GitlabHooksHandler, js nats.JetStreamContext) *Gitl | |||
| } | |||
|
|
|||
| func (w *GitlabEventWorker) processNoteEventStreamMsg(msg *NoteEventMsg) error { | |||
| ctx, span := otel.Tracer("hooks").Start(msg.Context, "CheckForMergeConflicts") | |||
There was a problem hiding this comment.
Is CheckForMergeConflicts correct?
pkg/vcs/github/client.go
Outdated
| // This is a NoOp on GitHub | ||
| return nil | ||
| } | ||
|
|
||
| func (c *Client) AddMergeRequestDiscussionReply(prID int, fullName, discussionID, comment string) (vcs.MRNote, error) { | ||
| func (c *Client) AddMergeRequestDiscussionReply(ctx context.Context, prID int, fullName, discussionID, comment string) (vcs.MRNote, error) { | ||
| ctx, span := otel.Tracer("TFC").Start(ctx, "ApplyMergeRequestDiscussionReply") |
There was a problem hiding this comment.
Was this meant to be AddMergeRequestDiscussionReply ?
There was a problem hiding this comment.
Yeah we might have renamed the method good catch
Signed-off-by: Matt Plachter <matthew.plachter@zapier.com>
davidwin93
approved these changes
Aug 16, 2023
ahinh43
pushed a commit
to ahinh43/tfbuddy
that referenced
this pull request
Sep 18, 2023
* add otel tracing to tfbuddy Signed-off-by: Matt Plachter <matthew.plachter@zapier.com> * change over from fmt to log Signed-off-by: Matt Plachter <matthew.plachter@zapier.com> * fix trace names Signed-off-by: Matt Plachter <matthew.plachter@zapier.com> --------- Signed-off-by: Matt Plachter <matthew.plachter@zapier.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Tracing to TFBuddy
Currently waiting on this sl1pm4t/gongs#3 to be merged than I'll update and sign DCO