Simple gradient descent works for callables without gradient #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts-function-to-callable-with-gradient
…t_function. Thus it should not require it to have a gradient method.
…ts-function-to-callable-with-gradient
Codecov ReportBase: 94.95% // Head: 94.02% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #30 +/- ##
==========================================
- Coverage 94.95% 94.02% -0.93%
==========================================
Files 28 28
Lines 1011 1038 +27
==========================================
+ Hits 960 976 +16
- Misses 51 62 +11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
VolodyaCO
requested review from
AthenaCaesura
and removed request for
mstechly
Co-authored-by: Athena Caesura <athena.caesura@zapatacomputing.com>
…-to-callable-with-gradient' of https://github.com/zapatacomputing/orquestra-opt into fix/volodyaco/simple-gradient-descent-converts-function-to-callable-with-gradient
AthenaCaesura
approved these changes
Mar 15, 2023
VolodyaCO
deleted the
fix/volodyaco/simple-gradient-descent-converts-function-to-callable-with-gradient
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, the simple gradient descent optimiser accepted both callables and callables with gradient. However, when passing a callable, it would not compute gradients with a numerical approximation routine, and the optimisation would fail. This PR wraps the incoming cost function, if it's just a callable, to convert it to a callable with gradient by using finite differences.
Please verify that you have completed the following steps