Skip to content

Commit

Permalink
include/linux/crash_dump.h: add vmcore_cleanup() prototype
Browse files Browse the repository at this point in the history
Eliminate the following warning in proc/vmcore.c:

  fs/proc/vmcore.c:1088:6: warning: no previous prototype for `vmcore_cleanup' [-Wmissing-prototypes]

[akpm@linux-foundation.org: clean up powerpc, remove unneeded EXPORT_SYMBOL]
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
rashika authored and torvalds committed Apr 7, 2014
1 parent 7c733eb commit 82e0703
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 2 deletions.
1 change: 0 additions & 1 deletion arch/powerpc/include/asm/fadump.h
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,6 @@ extern int is_fadump_active(void);
extern void crash_fadump(struct pt_regs *, const char *);
extern void fadump_cleanup(void);

extern void vmcore_cleanup(void);
#else /* CONFIG_FA_DUMP */
static inline int is_fadump_active(void) { return 0; }
static inline void crash_fadump(struct pt_regs *regs, const char *str) { }
Expand Down
1 change: 0 additions & 1 deletion fs/proc/vmcore.c
Original file line number Diff line number Diff line change
Expand Up @@ -1118,4 +1118,3 @@ void vmcore_cleanup(void)
}
free_elfcorebuf();
}
EXPORT_SYMBOL_GPL(vmcore_cleanup);
1 change: 1 addition & 0 deletions include/linux/crash_dump.h
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ extern int __weak remap_oldmem_pfn_range(struct vm_area_struct *vma,

extern ssize_t copy_oldmem_page(unsigned long, char *, size_t,
unsigned long, int);
void vmcore_cleanup(void);

/* Architecture code defines this if there are other possible ELF
* machine types, e.g. on bi-arch capable hardware. */
Expand Down

0 comments on commit 82e0703

Please sign in to comment.