Skip to content

Fix Python 3.13 builds on macOS #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 6, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "Bump target minimum macOS version from 10.13.0 to 10.13.4"
This reverts commit 4c7b4a5.
  • Loading branch information
zanieb committed Sep 6, 2024
commit a6499ca3cc59a912e5763b0fd71618e600d2942c
4 changes: 2 additions & 2 deletions cpython-unix/targets.yml
Original file line number Diff line number Diff line change
Expand Up @@ -566,7 +566,7 @@ x86_64-apple-darwin:
target_cflags:
- '-arch'
- 'x86_64'
- '-mmacosx-version-min=10.13.4'
- '-mmacosx-version-min=10.13'
# Suppress extremely verbose warnings we see with LLVM 10.
- '-Wno-nullability-completeness'
- '-Wno-expansion-to-defined'
Expand All @@ -581,7 +581,7 @@ x86_64-apple-darwin:
target_ldflags:
- '-arch'
- 'x86_64'
- '-mmacosx-version-min=10.13.4'
- '-mmacosx-version-min=10.13'
needs:
- autoconf
- bzip2
Expand Down
2 changes: 1 addition & 1 deletion src/validation.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1100,7 +1100,7 @@ fn validate_macho<Mach: MachHeader<Endian = Endianness>>(
bytes: &[u8],
) -> Result<()> {
let advertised_target_version =
semver::Version::parse(&format!("{}", advertised_target_version))?;
semver::Version::parse(&format!("{}.0", advertised_target_version))?;
let advertised_sdk_version = semver::Version::parse(&format!("{}.0", advertised_sdk_version))?;

let endian = header.endian()?;
Expand Down