Skip to content

Commit

Permalink
mac802154: remove wpan_dev parameter in if_add
Browse files Browse the repository at this point in the history
This parameter was grabbed from wireless implementation with the
identically wireless dev struct. We don't need this right now and so we
remove it. Maybe we will add it later again if we found any real reason
to have such parameter.

Signed-off-by: Alexander Aring <alex.aring@gmail.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
  • Loading branch information
alexaring authored and holtmann committed Nov 17, 2014
1 parent 944742a commit 133d3f3
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 7 deletions.
2 changes: 1 addition & 1 deletion net/mac802154/cfg.c
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ ieee802154_add_iface_deprecated(struct wpan_phy *wpan_phy,
struct net_device *dev;

rtnl_lock();
dev = ieee802154_if_add(local, name, NULL, type);
dev = ieee802154_if_add(local, name, type);
rtnl_unlock();

return dev;
Expand Down
2 changes: 1 addition & 1 deletion net/mac802154/ieee802154_i.h
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ void ieee802154_iface_exit(void);
void ieee802154_if_remove(struct ieee802154_sub_if_data *sdata);
struct net_device *
ieee802154_if_add(struct ieee802154_local *local, const char *name,
struct wpan_dev **new_wpan_dev, enum nl802154_iftype type);
enum nl802154_iftype type);
void ieee802154_remove_interfaces(struct ieee802154_local *local);

#endif /* __IEEE802154_I_H */
5 changes: 1 addition & 4 deletions net/mac802154/iface.c
Original file line number Diff line number Diff line change
Expand Up @@ -458,7 +458,7 @@ ieee802154_setup_sdata(struct ieee802154_sub_if_data *sdata,

struct net_device *
ieee802154_if_add(struct ieee802154_local *local, const char *name,
struct wpan_dev **new_wpan_dev, enum nl802154_iftype type)
enum nl802154_iftype type)
{
struct net_device *ndev = NULL;
struct ieee802154_sub_if_data *sdata = NULL;
Expand Down Expand Up @@ -516,9 +516,6 @@ ieee802154_if_add(struct ieee802154_local *local, const char *name,
list_add_tail_rcu(&sdata->list, &local->interfaces);
mutex_unlock(&local->iflist_mtx);

if (new_wpan_dev)
*new_wpan_dev = &sdata->wpan_dev;

return ndev;

err:
Expand Down
2 changes: 1 addition & 1 deletion net/mac802154/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ int ieee802154_register_hw(struct ieee802154_hw *hw)

rtnl_lock();

dev = ieee802154_if_add(local, "wpan%d", NULL, NL802154_IFTYPE_NODE);
dev = ieee802154_if_add(local, "wpan%d", NL802154_IFTYPE_NODE);
if (IS_ERR(dev)) {
rtnl_unlock();
rc = PTR_ERR(dev);
Expand Down

0 comments on commit 133d3f3

Please sign in to comment.