First design for Open Telemetry #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-zk
reviewed
Feb 13, 2024
youben11
force-pushed
the
feature/tracing
branch
from
2cbeca5
to
47f62d1
Compare
youben11
force-pushed
the
feature/tracing
branch
from
47f62d1
to
a1bf02c
Compare
leventdem
approved these changes
Feb 26, 2024
| defaultTracerName = "otel-instrumented-apps" | ||
| ) | ||
|
|
||
| func init() { |
There was a problem hiding this comment.
The issue with this init is that of we do not start jaeger on the collectorEndPoint, Ethermint is not starting at all there is no information to specify what happen's ? How can we solve it ? Can we call init from elsewhere to enable it through flags like here for pprof
youben11
force-pushed
the
feature/tracing
branch
from
cf400ba
to
95523dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This first design focus on the EVM execution, tracing important operations (fhEVM). We will look later onto how to extend this with more info for better observability
Related to zama-ai/fhevm-go#82