chore(gpu): refactor int_radix_lut #2793
Open
+503
−633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrei-stoian-zama
changed the title
andrei-stoian-zama
force-pushed
the
as/use_active_streams
branch
from
361acba to
72b1b11
Compare
andrei-stoian-zama
force-pushed
the
as/use_active_streams
branch
from
72b1b11 to
7f55a8c
Compare
andrei-stoian-zama
force-pushed
the
as/use_active_streams
branch
4 times, most recently
from
4ad639d to
bf9a5e4
Compare
agnesLeroy
reviewed
Oct 6, 2025
There was a problem hiding this comment.
Thanks a lot @andrei-stoian-zama, I did a first pass on the PR (not fully reviewed the changes in int_radix_lut yet).
andrei-stoian-zama
force-pushed
the
as/use_active_streams
branch
from
bf9a5e4 to
4a86800
Compare
agnesLeroy
reviewed
Oct 6, 2025
backends/tfhe-cuda-backend/cuda/include/integer/integer_utilities.h
Outdated
Show resolved
Hide resolved
agnesLeroy
reviewed
Oct 6, 2025
agnesLeroy
requested changes
Oct 6, 2025
andrei-stoian-zama
force-pushed
the
as/use_active_streams
branch
from
3f03058 to
3be7aae
Compare
backends/tfhe-cuda-backend/cuda/include/integer/integer_utilities.h
Outdated
Show resolved
Hide resolved
backends/tfhe-cuda-backend/cuda/include/integer/integer_utilities.h
Outdated
Show resolved
Hide resolved
agnesLeroy
reviewed
Oct 8, 2025
backends/tfhe-cuda-backend/cuda/include/integer/integer_utilities.h
Outdated
Show resolved
Hide resolved
andrei-stoian-zama
force-pushed
the
as/use_active_streams
branch
from
3be7aae to
2afe0e7
Compare
agnesLeroy
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring of
int_radix_lutto useactive_streamsand refactor constructors