chore(coprocessor): support for extraData in InputVerification and Mu… #636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for extraData parameter in InputVerification and MultichainAcl contracts and their corresponding Rust implementations. The change enables passing additional data alongside proof verification and account allowance operations.
Key changes:
- Add
extraDataparameter to smart contract methods and events - Update database schema to store extra data
- Modify Rust code to handle the new parameter in proof verification and allowance operations
Reviewed Changes
Copilot reviewed 7 out of 34 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| verify_proof.rs | Updates SQL query and struct to include extra_data field |
| allow_handle.rs | Adds empty extraData parameter to MultichainAcl method calls |
| MultichainAcl.sol | Updates contract methods to accept extraData parameter |
| gw_listener_tests.rs | Updates test to handle new extraData field |
| gw_listener.rs | Modifies database insert to include extra_data column |
| InputVerification.sol | Adds extraData parameter to event and method signature |
| 20250728110954_verify_proofs_extra_data.sql | Database migration to add extra_data column |
Files not reviewed (27)
- coprocessor/fhevm-engine/gw-listener/.sqlx/query-0d390882dbdd916d77eacede9469de25e573be481429f04c81beef17f3cf6802.json: Language not supported
- coprocessor/fhevm-engine/gw-listener/.sqlx/query-6d7ded0d4ae669d73f3102d587ff28837a50c63a860954012b4662e94b4a56e6.json: Language not supported
- coprocessor/fhevm-engine/gw-listener/.sqlx/query-84c5e88c6c98fd021781e6730664989697c8708668a0d7498f83f54cc9270913.json: Language not supported
- coprocessor/fhevm-engine/gw-listener/.sqlx/query-d1a294c48d897dc9685c95c8a59be64262d55e5d5b1dcbf40ae6d829fbc02970.json: Language not supported
- coprocessor/fhevm-engine/transaction-sender/.sqlx/query-048212909e0bbe46633e404235d2c5cffb5284903adb757b4fda59b7fbe81d57.json: Language not supported
- coprocessor/fhevm-engine/transaction-sender/.sqlx/query-09f4bb2ed7df17aa0305c7fb88e87473e5be704202eb8f2fa571d47a4f98b7af.json: Language not supported
- coprocessor/fhevm-engine/transaction-sender/.sqlx/query-10302a1039344f5a16d305330eeabdcf90ec0834c1191934911c22387ba4a807.json: Language not supported
- coprocessor/fhevm-engine/transaction-sender/.sqlx/query-199e8868ec5429343da585c5b037a4e9fce69066aec12225508a9d5a61064a72.json: Language not supported
- coprocessor/fhevm-engine/transaction-sender/.sqlx/query-2611f503726ca2bd9cb05c62058395cf36c079ed4e0f7a9111e46e2b9a391b8c.json: Language not supported
- coprocessor/fhevm-engine/transaction-sender/.sqlx/query-2637d7e49fbc45e9051a9a4b098464aec3b13a8b311e71d962b6fb173b671b09.json: Language not supported
- coprocessor/fhevm-engine/transaction-sender/.sqlx/query-355e54c5e8527ac44a96a2a1e1bf42341e9704a8bacb703eef5b3e58b6fa4ab3.json: Language not supported
- coprocessor/fhevm-engine/transaction-sender/.sqlx/query-419270adb3a13e9e491adf9611a564b908ee87b1e43211ac6ba5bf60753e1940.json: Language not supported
- coprocessor/fhevm-engine/transaction-sender/.sqlx/query-4d3ad8176c68cea2ecca904e52c7e3abf2c8ea6e0eca45a42132549661fa4e54.json: Language not supported
- coprocessor/fhevm-engine/transaction-sender/.sqlx/query-50f019940b924bfc9f1a317b5b9ea97e02b9ef8646642042755b4fe7f2ddce5b.json: Language not supported
- coprocessor/fhevm-engine/transaction-sender/.sqlx/query-556dbda2415973bd6d94b8455eeae8cb8e4e177cd72376a7acad880eef60e419.json: Language not supported
- coprocessor/fhevm-engine/transaction-sender/.sqlx/query-5631176c0419193e1007788434d8786ea0872b263ad07a2c7c205a8b04d041b8.json: Language not supported
- coprocessor/fhevm-engine/transaction-sender/.sqlx/query-6ad98c10b69f3b51f3da346ec4099672a6caffdd4bb6367aec376a9f48178609.json: Language not supported
- coprocessor/fhevm-engine/transaction-sender/.sqlx/query-7e4f6abc7e18549f31548130efa4bed4d267da6e28697ceb780a58d787e739f1.json: Language not supported
- coprocessor/fhevm-engine/transaction-sender/.sqlx/query-92524ec746c5f2a7dd986cacd005d98d68a8fe112f1e8310c3a78e4e208dcd39.json: Language not supported
- coprocessor/fhevm-engine/transaction-sender/.sqlx/query-a3581b82aa78344b06e4270d0aec5ac76c2d0fa1661c1502600852450d92fe8a.json: Language not supported
- coprocessor/fhevm-engine/transaction-sender/.sqlx/query-ad702e3febf9f7dea99259e19f36b7da23fc42f7363e1f9f29d15f7d94e8fe56.json: Language not supported
- coprocessor/fhevm-engine/transaction-sender/.sqlx/query-b5b633e5812b7396037e2ab0a1db9a1d753b8650ed3367681ba30ed426799502.json: Language not supported
- coprocessor/fhevm-engine/transaction-sender/.sqlx/query-b7d5ed966527dfc500ce529e0249d96c058a06c18a02ed117ad2f4140fbc470f.json: Language not supported
- coprocessor/fhevm-engine/transaction-sender/.sqlx/query-b81fa0a977cef565274a254e103b9c07e2fc03f0ab34e62edf83c8fc104b65b3.json: Language not supported
- coprocessor/fhevm-engine/transaction-sender/.sqlx/query-be2b163e885ff2e4df27ae07c51f8c304f534b50565504a96bd63ce63a6179d7.json: Language not supported
- coprocessor/fhevm-engine/transaction-sender/.sqlx/query-d1d558d9f86eae97eb9fd0b16b1e0bf4ad00f66119c50381c0673a0d2433567b.json: Language not supported
- coprocessor/fhevm-engine/transaction-sender/.sqlx/query-eadec222d0154713dc15ea7ba1e113ae7838d935e4462421fd796f5f7986dbbd.json: Language not supported
Comments suppressed due to low confidence (1)
coprocessor/fhevm-engine/transaction-sender/src/ops/allow_handle.rs:386
- [nitpick] The variable name
extra_datauses snake_case but should follow Rust naming conventions. Consider renaming toextra_dataif this is the intended style, or use camelCase if that's the project standard.
let extra_data = Bytes::new();
coprocessor/fhevm-engine/gw-listener/tests/gw_listener_tests.rs
Outdated
Show resolved
Hide resolved
dartdart26
force-pushed
the
petar/extra-data
branch
2 times, most recently
from
6495ea1 to
3e6a5ad
Compare
eudelins-zama
changed the base branch from
main
to
feature/generic-bytes-metadata
eudelins-zama
force-pushed
the
petar/extra-data
branch
from
3e6a5ad to
98a62e1
Compare
…ltichainAcl Related to a405734 Resolves zama-ai/fhevm-internal#270
eudelins-zama
force-pushed
the
petar/extra-data
branch
from
98a62e1 to
befd982
Compare
eudelins-zama
merged commit 9133618
into
feature/generic-bytes-metadata
101 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ltichainAcl
Related to a405734
Resolves https://github.com/zama-ai/fhevm-internal/issues/270