Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): add fhevm smart contracts docker workflows #595

Merged
merged 8 commits into from
Oct 30, 2024

Conversation

0xawaz
Copy link
Contributor

@0xawaz 0xawaz commented Oct 29, 2024

No description provided.

@0xawaz 0xawaz marked this pull request as ready for review October 29, 2024 12:26
annotations: |
org.opencontainers.image.description="${{ inputs.image-dev-description }}"
labels: |
zama.kms.version=${{ env.DOCKER_TAG_IMAGE }}
Copy link
Contributor

@leventdem leventdem Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we can set docker tag as maybe zama.fhevm.version

COPY *.sh ./
COPY *.ts ./
COPY tsconfig.json ./
COPY *.sh ./
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can remove this duplicate

Copy link
Contributor

@leventdem leventdem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments. Good to merge after.

@0xawaz 0xawaz merged commit c5e6f87 into main Oct 30, 2024
3 checks passed
@0xawaz 0xawaz deleted the amina/fhevm-sc-workflows branch October 30, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants