-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): add fhevm smart contracts docker workflows #595
Conversation
.github/workflows/common-docker.yml
Outdated
annotations: | | ||
org.opencontainers.image.description="${{ inputs.image-dev-description }}" | ||
labels: | | ||
zama.kms.version=${{ env.DOCKER_TAG_IMAGE }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we can set docker tag as maybe zama.fhevm.version
operations/docker/ci.dockerfile
Outdated
COPY *.sh ./ | ||
COPY *.ts ./ | ||
COPY tsconfig.json ./ | ||
COPY *.sh ./ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can remove this duplicate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor comments. Good to merge after.
No description provided.