Enables links for blips. Makes link target configurable. #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes a few things about links: 1. Links are now always enabled for blips Previously, it was only enabled for blips if there is no legend (config.print_layout = true) 2. hrefs are only added if there is actually a link Previously, there were always href created--if there was no link, the href was #. This caused a page refresh and a blink of the tech radar. 3. Use xlink:href everywhere Previously, blips used xlink:href, but text still used href. xlink:href has actually been deprecated, but currently still has better cross-platform support. 4. Links can now open in new tabs Previously, links always opened in the existing tab. This adds a new config: links_in_new_tabs. Setting that to true will add a target="_blank" for all hrefs, causing the link to be opened in a new tab. Setting config.links_in_new_tabs to false or not including it at all retains the old behavior.
… tech radar visualization
Empty <a> tags negatively affect the SEO score (as measured by Chrome's Lighthouse plugin).
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes changes from #73.
Previously, it was only enabled for blips if there is
no legend (config.print_layout = true)
Previously, blips used xlink:href, but text still used href.
xlink:href has actually been deprecated, but currently still
has better cross-platform support.
Previously, links always opened in the existing tab. This adds
a new config: links_in_new_tabs. Setting that to true will
add a target="_blank" for all hrefs, causing the link to be
opened in a new tab. Setting config.links_in_new_tabs to false
or not including it at all retains the old behavior.