Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to IMDSv2 and boto3 #967

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Switch to IMDSv2 and boto3 #967

wants to merge 8 commits into from
+50 −42

Conversation

idanovinda
Copy link
Member

  • retrieve and add token to the curl request headers to replace the usage of IMDSv1 to IMDSv2
  • replace boto with boto3 library

@idanovinda idanovinda marked this pull request as ready for review January 29, 2024 15:10
@hughcapet hughcapet marked this pull request as draft January 29, 2024 17:07
@hughcapet hughcapet mentioned this pull request Feb 19, 2024
Closed
@hughcapet hughcapet linked an issue Feb 19, 2024 that may be closed by this pull request
AWS IMDSv2 Support for environment detection #963
Open
@idanovinda idanovinda marked this pull request as ready for review February 26, 2024 12:54
@hughcapet hughcapet changed the title Switch to IMDSv2 Switch to IMDSv2 and boto3 Mar 7, 2024
@laiminhtrung1997
Copy link

Dear all,
If I followed the best practices for security, the spilo container's pod could not access IMDS anymore. So I have to configure the pod to run as hostNetwork so that it can access IMDS.
What do you guys think about this scenario?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hughcapet hughcapet hughcapet left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AWS IMDSv2 Support for environment detection
3 participants
@idanovinda @laiminhtrung1997 @hughcapet