feat: add support for disabling route polling - #3722
Closed
MustafaSaber wants to merge 2 commits into
Closed
Conversation
MustafaSaber
added
the
major
Deployment ChecklistThis change falls under the deployment policy. 💁 Since Nov 10th, we are in the RED deployment zone. This means all changes released to production must adhere to the following requirements:
👉 Regardless of which boxes you click in this comment, merge/deployment will not be blocked. |
Member
|
I think we should not use 0, but maybe -1 |
szuecs
reviewed
Nov 11, 2025
|
|
||
| // ensure a non-zero poll timeout | ||
| if o.SourcePollTimeout <= 0 { | ||
| if o.SourcePollTimeout < 0 { |
Collaborator
Author
There was a problem hiding this comment.
The default is already int64(3000) it's what we use now. We only update to use the default in case of invalid input like 0 or negative
szuecs
reviewed
Nov 11, 2025
| flag.StringVar(&cfg.InlineRoutes, "inline-routes", "", "inline routes in eskip format") | ||
| flag.StringVar(&cfg.ForwardBackendURL, "forward-backend-url", "", "target url of the <forward> backend") | ||
| flag.Int64Var(&cfg.SourcePollTimeout, "source-poll-timeout", int64(3000), "polling timeout of the routing data sources, in milliseconds") | ||
| flag.Int64Var(&cfg.SourcePollTimeout, "source-poll-timeout", int64(3000), "polling timeout of the routing data sources, in milliseconds. Use 0 to not poll routes.") |
Member
There was a problem hiding this comment.
This is not enough to create a default other than 0
Collaborator
Author
There was a problem hiding this comment.
Why not enough?
szuecs
requested changes
Nov 11, 2025
szuecs
left a comment
szuecs
left a comment
Member
There was a problem hiding this comment.
Disable on <0 and 0 is default, which sets our chosen default.
vlktna
reviewed
Nov 11, 2025
- Add ability to disable route polling by setting source-poll-timeout to 0 - Return HTTP 204 No Content when polling is disabled Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
… is because 0 will override routing.Options and most tests will fail Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
MustafaSaber
force-pushed
the
block-routing-polls-if-not-needed
branch
from
November 11, 2025 14:59
a03cb0f to
2605b4c
Compare
MustafaSaber
added a commit
that referenced
this pull request
Nov 12, 2025
This allows k8s dataclient to run without loading routing table (which won't call apisever), this will allow us to use k8s dataclient in webhook mode to enable some filters without calling apiserver and may allow us later to get redis endpoints wihout calling routeSRV. This should replace #3722 which disable polling routing across all dataclients which maybe not desriable.
MustafaSaber
added a commit
that referenced
this pull request
Nov 12, 2025
This allows k8s dataclient to run without loading routing table (which won't call apisever), this will allow us to use k8s dataclient in webhook mode to enable some filters without calling apiserver and may allow us later to get redis endpoints wihout calling routeSRV. This should replace #3722 which disable polling routing across all dataclients which maybe not desriable. Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
Collaborator
Author
|
close in favor of #3729 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will help with running
skipperbinary in webhook mode as we need to use-kubernetesflag to enable some filter registries but we don't want skipper to overload/pull data from k8s apiserver