minor: remove unused endpointRegistry field from healthyEndpoints and fadeIn #3248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roman Zavodskikh <roman.zavodskikh@zalando.de>
|
I think this related is also unused Line 13 in 8ea6c5b |
Signed-off-by: Roman Zavodskikh <roman.zavodskikh@zalando.de>
RomanZavodskikh
changed the title
|
@AlexanderYastrebov thanks for a good catch, I have removed. |
|
👍 |
|
restarted pipeline |
|
👍 |
1 similar comment
|
👍 |
RomanZavodskikh
pushed a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Sep 25, 2024
+ zalando/skipper#3227 + zalando/skipper#3225 + zalando/skipper#3234 + zalando/skipper#3239 + zalando/skipper#3240 + zalando/skipper#3241 + zalando/skipper#3242 + zalando/skipper#3245 + zalando/skipper#3246 + zalando/skipper#3247 + zalando/skipper#3249 + zalando/skipper#3248 FYI zalando/skipper@v0.21.198...v0.21.208 Signed-off-by: Roman Zavodskikh <roman.zavodskikh@zalando.de>
RomanZavodskikh
pushed a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Sep 26, 2024
+ zalando/skipper#3227 + zalando/skipper#3225 + zalando/skipper#3234 + zalando/skipper#3239 + zalando/skipper#3240 + zalando/skipper#3241 + zalando/skipper#3242 + zalando/skipper#3245 + zalando/skipper#3246 + zalando/skipper#3247 + zalando/skipper#3249 + zalando/skipper#3248 FYI zalando/skipper@v0.21.198...v0.21.208 Signed-off-by: Roman Zavodskikh <roman.zavodskikh@zalando.de>
RomanZavodskikh
pushed a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Sep 30, 2024
+ zalando/skipper#3227 + zalando/skipper#3225 + zalando/skipper#3234 + zalando/skipper#3239 + zalando/skipper#3240 + zalando/skipper#3241 + zalando/skipper#3242 + zalando/skipper#3245 + zalando/skipper#3246 + zalando/skipper#3247 + zalando/skipper#3249 + zalando/skipper#3248 FYI zalando/skipper@v0.21.198...v0.21.208 canary was updated #8214 Signed-off-by: Roman Zavodskikh <roman.zavodskikh@zalando.de>
Pushpalanka
pushed a commit
that referenced
this pull request
Oct 11, 2024
… fadeIn (#3248) Signed-off-by: Roman Zavodskikh <roman.zavodskikh@zalando.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small removal of unsued field.