Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix HeaderRegexp example #3222

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

AlexanderYastrebov
Copy link
Member

From https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Forwarded-For

Elements are comma-separated, with optional whitespace surrounding the commas.
If a request goes through multiple proxies, the IP addresses of each successive proxy is listed.
This means that, given well-behaved client and proxies, the rightmost IP address is the IP address
of the most recent proxy and the leftmost IP address is the IP address of the originating client.

Fix example by removing trailing space.

From https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Forwarded-For

> Elements are comma-separated, with optional whitespace surrounding the commas.
> If a request goes through multiple proxies, the IP addresses of each successive proxy is listed.
> This means that, given well-behaved client and proxies, the rightmost IP address is the IP address
> of the most recent proxy and the leftmost IP address is the IP address of the originating client.

Fix example by removing trailing space.

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
@szuecs szuecs added the minor no risk changes, for example new filters label Sep 10, 2024
@szuecs
Copy link
Member

szuecs commented Sep 10, 2024

👍

1 similar comment
@AlexanderYastrebov
Copy link
Member Author

👍

@AlexanderYastrebov AlexanderYastrebov merged commit 04972ff into master Sep 10, 2024
14 checks passed
@AlexanderYastrebov AlexanderYastrebov deleted the fix-HeaderRegexp-example branch September 10, 2024 15:09
Pushpalanka pushed a commit that referenced this pull request Oct 11, 2024
From https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Forwarded-For

> Elements are comma-separated, with optional whitespace surrounding the commas.
> If a request goes through multiple proxies, the IP addresses of each successive proxy is listed.
> This means that, given well-behaved client and proxies, the rightmost IP address is the IP address
> of the most recent proxy and the leftmost IP address is the IP address of the originating client.

Fix example by removing trailing space.

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation minor no risk changes, for example new filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants