Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

routing: measure CreateFilter latency #3115

Merged
merged 1 commit into from
Jun 19, 2024
Merged

routing: measure CreateFilter latency #3115

merged 1 commit into from
Jun 19, 2024

Conversation

AlexanderYastrebov
Copy link
Member

Add MeasureFilterCreate method to Metrics interface similar to existing MeasureFilterRequest and MeasureFilterResponse.

The alternative would be to use MeasureSince but then filter name would have to be embedded into metric key.

@AlexanderYastrebov AlexanderYastrebov added the minor no risk changes, for example new filters label Jun 18, 2024
@AlexanderYastrebov AlexanderYastrebov force-pushed the routing/measure-create-filter-latency branch from 1a39c41 to 30c7fae Compare June 18, 2024 15:35
@AlexanderYastrebov AlexanderYastrebov marked this pull request as ready for review June 18, 2024 15:36
szuecs
szuecs reviewed Jun 18, 2024
View reviewed changes
routing/datasource.go Outdated Show resolved Hide resolved
@AlexanderYastrebov
routing: measure CreateFilter latency
8f4f2a6 
Add `MeasureFilterCreate` method to `Metrics` interface similar to
existing `MeasureFilterRequest` and `MeasureFilterResponse`.

The alternative would be to use `MeasureSince` but then filter name
would have to be embedded into metric key.

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
@AlexanderYastrebov AlexanderYastrebov force-pushed the routing/measure-create-filter-latency branch from 30c7fae to 8f4f2a6 Compare June 18, 2024 16:46
@MustafaSaber
Copy link
Member

should we update docs on the same PR?

@szuecs
Copy link
Member

szuecs commented Jun 19, 2024

👍

@szuecs
Copy link
Member

szuecs commented Jun 19, 2024

should we update docs on the same PR?

In this case I think we can do the docs later, because we should make sure we have useful docs in our operations doc.
We should write about it why would you should monitor this, so I think we should add a new paragraph to monitor some control plane parts.

@MustafaSaber
Copy link
Member

👍

@MustafaSaber MustafaSaber merged commit 9bf19e4 into master Jun 19, 2024
14 checks passed
@MustafaSaber MustafaSaber deleted the routing/measure-create-filter-latency branch June 19, 2024 11:47
MustafaSaber referenced this pull request in zalando-incubator/kubernetes-on-aws Jun 20, 2024
@MustafaSaber
update skipper canary version
da5ce95 
* \[docs: cleanup deprecated -lb-healthcheck-interval flag\]\(https://github.com/zalando/skipper/pull/3099\)
* \[build(deps): bump amazonlinux from 5478f82 to 0d172f8 in /fuzz \]\(https://github.com/zalando/skipper/pull/3105\)
* \[build(deps): bump golang.org/x/net from 0.25.0 to 0.26.0\]\(\zalando/skipper#3100)
* \[build(deps): bump github.com/instana/go-sensor from 1.62.1 to 1.63.0\]\(https://github.com/zalando/skipper/pull/3104\)
* \[build(deps): bump golang.org/x/oauth2 from 0.20.0 to 0.21.0\]\(https://github.com/zalando/skipper/pull/3102\)
* \[build(deps): bump docker/build-push-action from 5.3.0 to 5.4.0\]\(https://github.com/zalando/skipper/pull/3106\)
* \[build(deps): bump github.com/miekg/dns from 1.1.59 to 1.1.61\]\(https://github.com/zalando/skipper/pull/3109\)
* \[build(deps): bump github.com/redis/go-redis/v9 from 9.5.2 to 9.5.3\]\(https://github.com/zalando/skipper/pull/3110\)
* \[build(deps): bump google.golang.org/protobuf from 1.34.1 to 1.34.2\]\(https://github.com/zalando/skipper/pull/3108\)
* \[routing: log route update id\]\(https://github.com/zalando/skipper/pull/3112\)
* \[build(deps): bump actions/checkout from 4.1.6 to 4.1.7\]\(https://github.com/zalando/skipper/pull/3107\)
* \[routing: measure route update latency\]\(https://github.com/zalando/skipper/pull/3113\)
* \[doc: mention DCO and what to do in your commit\]\(https://github.com/zalando/skipper/pull/3114\)
* \[routing: refactor update id logging\]\(https://github.com/zalando/skipper/pull/3116\)
* \[OPA: Add response status to control plane traces\]\(https://github.com/zalando/skipper/pull/3118\)
* \[routing: measure CreateFilter latency\]\(https://github.com/zalando/skipper/pull/3115\)

Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
MustafaSaber added a commit to zalando-incubator/kubernetes-on-aws that referenced this pull request Jun 20, 2024
@MustafaSaber
update skipper canary version
9ef7041 
* docs: cleanup deprecated -lb-healthcheck-interval flag: zalando/skipper#3099
* build(deps): bump amazonlinux from 5478f82 to 0d172f8 in /fuzz: zalando/skipper#3105
* build(deps): bump golang.org/x/net from 0.25.0 to 0.26.0: zalando/skipper#3100
* build(deps): bump github.com/instana/go-sensor from 1.62.1 to 1.63.0: zalando/skipper#3104
* build(deps): bump golang.org/x/oauth2 from 0.20.0 to 0.21.0: zalando/skipper#3102
* build(deps): bump docker/build-push-action from 5.3.0 to 5.4.0: zalando/skipper#3106
* build(deps): bump github.com/miekg/dns from 1.1.59 to 1.1.61: zalando/skipper#3109
* build(deps): bump github.com/redis/go-redis/v9 from 9.5.2 to 9.5.3: zalando/skipper#3110
* build(deps): bump google.golang.org/protobuf from 1.34.1 to 1.34.2: zalando/skipper#3108
* routing: log route update id: zalando/skipper#3112
* build(deps): bump actions/checkout from 4.1.6 to 4.1.7: zalando/skipper#3107
* routing: measure route update latency: zalando/skipper#3113
* doc: mention DCO and what to do in your commit: zalando/skipper#3114
* routing: refactor update id logging: zalando/skipper#3116
* OPA: Add response status to control plane traces: zalando/skipper#3118
* routing: measure CreateFilter latency: zalando/skipper#3115

Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
@MustafaSaber MustafaSaber mentioned this pull request Jun 20, 2024
Merged
MustafaSaber added a commit to zalando-incubator/kubernetes-on-aws that referenced this pull request Jun 20, 2024
@MustafaSaber
update skipper canary version
a91f4b3 
* docs: cleanup deprecated -lb-healthcheck-interval flag: zalando/skipper#3099
* build(deps): bump amazonlinux from 5478f82 to 0d172f8 in /fuzz: zalando/skipper#3105
* build(deps): bump golang.org/x/net from 0.25.0 to 0.26.0: zalando/skipper#3100
* build(deps): bump github.com/instana/go-sensor from 1.62.1 to 1.63.0: zalando/skipper#3104
* build(deps): bump golang.org/x/oauth2 from 0.20.0 to 0.21.0: zalando/skipper#3102
* build(deps): bump docker/build-push-action from 5.3.0 to 5.4.0: zalando/skipper#3106
* build(deps): bump github.com/miekg/dns from 1.1.59 to 1.1.61: zalando/skipper#3109
* build(deps): bump github.com/redis/go-redis/v9 from 9.5.2 to 9.5.3: zalando/skipper#3110
* build(deps): bump google.golang.org/protobuf from 1.34.1 to 1.34.2: zalando/skipper#3108
* routing: log route update id: zalando/skipper#3112
* build(deps): bump actions/checkout from 4.1.6 to 4.1.7: zalando/skipper#3107
* routing: measure route update latency: zalando/skipper#3113
* doc: mention DCO and what to do in your commit: zalando/skipper#3114
* routing: refactor update id logging: zalando/skipper#3116
* OPA: Add response status to control plane traces: zalando/skipper#3118
* routing: measure CreateFilter latency: zalando/skipper#3115

Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
MustafaSaber added a commit to zalando-incubator/kubernetes-on-aws that referenced this pull request Jun 20, 2024
@MustafaSaber
update skipper canary version
4198e41 
* docs: cleanup deprecated -lb-healthcheck-interval flag: zalando/skipper#3099
* build(deps): bump amazonlinux from 5478f82 to 0d172f8 in /fuzz: zalando/skipper#3105
* build(deps): bump golang.org/x/net from 0.25.0 to 0.26.0: zalando/skipper#3100
* build(deps): bump github.com/instana/go-sensor from 1.62.1 to 1.63.0: zalando/skipper#3104
* build(deps): bump golang.org/x/oauth2 from 0.20.0 to 0.21.0: zalando/skipper#3102
* build(deps): bump docker/build-push-action from 5.3.0 to 5.4.0: zalando/skipper#3106
* build(deps): bump github.com/miekg/dns from 1.1.59 to 1.1.61: zalando/skipper#3109
* build(deps): bump github.com/redis/go-redis/v9 from 9.5.2 to 9.5.3: zalando/skipper#3110
* build(deps): bump google.golang.org/protobuf from 1.34.1 to 1.34.2: zalando/skipper#3108
* routing: log route update id: zalando/skipper#3112
* build(deps): bump actions/checkout from 4.1.6 to 4.1.7: zalando/skipper#3107
* routing: measure route update latency: zalando/skipper#3113
* doc: mention DCO and what to do in your commit: zalando/skipper#3114
* routing: refactor update id logging: zalando/skipper#3116
* OPA: Add response status to control plane traces: zalando/skipper#3118
* routing: measure CreateFilter latency: zalando/skipper#3115

Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
MustafaSaber added a commit to zalando-incubator/kubernetes-on-aws that referenced this pull request Jun 20, 2024
@MustafaSaber
update skipper main fleet
42490ad 
* docs: cleanup deprecated -lb-healthcheck-interval flag: zalando/skipper#3099
* build(deps): bump amazonlinux from 5478f82 to 0d172f8 in /fuzz: zalando/skipper#3105
* build(deps): bump golang.org/x/net from 0.25.0 to 0.26.0: zalando/skipper#3100
* build(deps): bump github.com/instana/go-sensor from 1.62.1 to 1.63.0: zalando/skipper#3104
* build(deps): bump golang.org/x/oauth2 from 0.20.0 to 0.21.0: zalando/skipper#3102
* build(deps): bump github.com/miekg/dns from 1.1.59 to 1.1.61: zalando/skipper#3109
* build(deps): bump github.com/redis/go-redis/v9 from 9.5.2 to 9.5.3: zalando/skipper#3110
* build(deps): bump google.golang.org/protobuf from 1.34.1 to 1.34.2: zalando/skipper#3108
* routing: log route update id: zalando/skipper#3112
* build(deps): bump actions/checkout from 4.1.6 to 4.1.7: zalando/skipper#3107
* routing: measure route update latency: zalando/skipper#3113
* doc: mention DCO and what to do in your commit: zalando/skipper#3114
* routing: refactor update id logging: zalando/skipper#3116
* OPA: Add response status to control plane traces: zalando/skipper#3118
* routing: measure CreateFilter latency: zalando/skipper#3115

Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
@MustafaSaber MustafaSaber mentioned this pull request Jun 20, 2024
Merged
AlexanderYastrebov added a commit that referenced this pull request Jun 26, 2024
@AlexanderYastrebov
metrics: register skipper_filter_create_duration_seconds
0d98653 
Follow up on #3115

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
@AlexanderYastrebov AlexanderYastrebov mentioned this pull request Jun 26, 2024
Merged
JanardhanSharma pushed a commit to JanardhanSharma/skipper that referenced this pull request Jul 19, 2024
@AlexanderYastrebov
routing: measure CreateFilter latency (zalando#3115)
deeea50 
Add `MeasureFilterCreate` method to `Metrics` interface similar to
existing `MeasureFilterRequest` and `MeasureFilterResponse`.

The alternative would be to use `MeasureSince` but then filter name
would have to be embedded into metric key.

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
@zalando-teapot-robot zalando-teapot-robot mentioned this pull request Sep 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szuecs szuecs szuecs left review comments

Assignees
No one assigned
Labels
minor no risk changes, for example new filters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexanderYastrebov @MustafaSaber @szuecs